Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with typeguard package v3 #234

Closed
jleben opened this issue Mar 15, 2023 · 3 comments · Fixed by #235
Closed

Issues with typeguard package v3 #234

jleben opened this issue Mar 15, 2023 · 3 comments · Fixed by #235

Comments

@jleben
Copy link

jleben commented Mar 15, 2023

typeguard version 3 does not have the argname argument to check_type(), raising an exception in marshmallow_dataclass.

Moreover, the version of typeguard is not constrained in setup.py, causing a silent upgrade of typeguard in projects that use marshmallow_dataclass even when those projects fully constrain the version of marshmallow_dataclass, which breaks those projects in a surprising way. It caused me an hour to debug one of my projects. The version of typeguard should have at least the major version number contrained.

@anzhurov
Copy link

Our project also facing that issue.

Please, fix the places of using typeguard.check_type and also strictly set typeguard version to avoid such situation in future.

Please, do that asap

@dairiki
Copy link
Collaborator

dairiki commented Mar 15, 2023

You all are kind of pushy! Realize that we all work for free here.

If you can check out/review #235 to make sure that fixes things for you, that would be great.

@dairiki
Copy link
Collaborator

dairiki commented Mar 16, 2023

Hopefully fixed as of marshmallow_dataclass==8.5.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants