-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
love.threaderror isn't called if error message is empty #1775
Comments
Looks intentional love/src/modules/thread/LuaThread.cpp Lines 106 to 107 in 8e7fd10
|
But if you look at the code above that, you'll see this: love/src/modules/thread/LuaThread.cpp Lines 89 to 90 in 8e7fd10
I might be wrong, but, onError gets called by that if error's not empty... yet inside onError, it is tested if it's empty again, which it can't be? |
There's probably other cases onError may be triggered |
In any case, i'd assume that an empty error call should still pass an empty string to threaderror since an error was raised. |
Yes, I think the core problem with the code is that it's using the |
The above code doesn't show default
love.threaderror
as expected (or a custom setlove.threaderror
). Not a massive bug - but something to be aware of if no error message is givenThe text was updated successfully, but these errors were encountered: