Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linuxmusl-arm64 binaries #72

Closed
gpetrov opened this issue Dec 18, 2020 · 6 comments · Fixed by #90
Closed

Add linuxmusl-arm64 binaries #72

gpetrov opened this issue Dec 18, 2020 · 6 comments · Fixed by #90

Comments

@gpetrov
Copy link

gpetrov commented Dec 18, 2020

Could you please add linuxmusl-arm64 binary generation?

Currently only linuxmusl-x64 binaries are being generated and we need musl arm64 binaries for node-alpine.

Seems to me the current build script and docker images can handle it already, just need an extra build target.

It will be a great Christmas present - now that the pubs are closed :)

@lovell
Copy link
Owner

lovell commented Dec 18, 2020

PR welcome if you're able.

@Casuallynoted
Copy link

+1 to this, currently trying to build a docker image that depends on libvips but it won't compile due to the binaries not being available. Won't compile either.

@gpetrov
Copy link
Author

gpetrov commented Dec 21, 2020

almost succeeded with the build for muse @lovell ! Fixed a very nasty issue with harfbuzz harfbuzz/harfbuzz#2771

Just one final road block of some dependency mixture:

   Compiling glib v0.9.3
   Compiling librsvg_c_api v0.0.1 (/deps/svg/librsvg)
    Finished release [optimized] target(s) in 1m 10s
ar: `u' modifier ignored since `D' is the default (see `U')
  CCLD     librsvg-2.la
libtool:   error: object name conflicts in archive: .libs/librsvg-2.lax/librsvg_c_api.a//deps/svg/./.libs/librsvg_c_api.a
make[3]: *** [Makefile:998: librsvg-2.la] Error 1
make[3]: Leaving directory '/deps/svg'
make[2]: *** [Makefile:1277: install-recursive] Error 1
make[2]: Leaving directory '/deps/svg'
make[1]: *** [Makefile:1584: install] Error 2
make[1]: Leaving directory '/deps/svg'

any idea what that might be?

@gpetrov
Copy link
Author

gpetrov commented Dec 21, 2020

all solved - made it optional as it seems it was included by the dependencies.

here is the PR #73

@lovell
Copy link
Owner

lovell commented Mar 1, 2021

PR #90 added this - I'm going to re-open this issue until we ship test a release that uses it.

@lovell lovell reopened this Mar 1, 2021
@lovell
Copy link
Owner

lovell commented Mar 7, 2021

The new linuxmusl-arm64v8 libvips binaries are now tested as part of sharp's CI process, which means prebuilt linuxmusl-arm64 sharp binaries will also be provided from the next release - see https://travis-ci.org/github/lovell/sharp/builds/761832277

Thanks all for your help with this.

@lovell lovell closed this as completed Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants