From 73e8258f76590a36be9ca75e99a8e2eee852c3fb Mon Sep 17 00:00:00 2001 From: Pascal Nasahl Date: Tue, 24 Sep 2024 13:48:01 +0000 Subject: [PATCH] [tlul/rtl] Modify readback check error reporting logic Currently, only a readback error check is reported when the `error_i` signal is not raised. However, as this signal is also raised when there is no activity on the TL-UL bus, we might miss some readback failures. This commit modifies the error reporting logic to also report the readback mismatch when the error signal is raised. Closes #24698. Signed-off-by: Pascal Nasahl --- hw/ip/tlul/rtl/tlul_sram_byte.sv | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ip/tlul/rtl/tlul_sram_byte.sv b/hw/ip/tlul/rtl/tlul_sram_byte.sv index f827f4f534949..d4ca08a4771a4 100644 --- a/hw/ip/tlul/rtl/tlul_sram_byte.sv +++ b/hw/ip/tlul/rtl/tlul_sram_byte.sv @@ -262,8 +262,8 @@ module tlul_sram_byte import tlul_pkg::*; #( rdback_wait = 1'b1; rdback_check_d = MuBi4False; - // Perform the readback check. Omit the check if the transaction contains an error. - if (!rdback_chk_ok && !error_i) begin + // Perform the readback check. + if (!rdback_chk_ok) begin alert_o = 1'b1; end end