Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞: Crop image where content ends #33

Closed
yozachar opened this issue Dec 31, 2020 · 4 comments · Fixed by #35
Closed

🐞: Crop image where content ends #33

yozachar opened this issue Dec 31, 2020 · 4 comments · Fixed by #35

Comments

@yozachar
Copy link
Contributor

yozachar commented Dec 31, 2020

Bug description
Hi, There's a noticeable space after the content in the generated image.

Expected behavior
The image is cropped right after the content ends.

To Reproduce
Quite nothing, just make sure metrics is in the ReadMe. 🙂

Additional context and screenshots

Phone Desktop
photo_2020-12-31_12-58-16 Screenshot from 2020-12-31 13-02-48
@lowlighter
Copy link
Owner

I'll look into it when I have some time.
I have a few leads to solve this but haven't tried them yet.

The workaround is to split your metrics into multiple images, but it's not very practical (it's because the padding mostly depends on enabled plugins)

@lowlighter
Copy link
Owner

It's better now, but it still needs some padding, will add it later

@lowlighter lowlighter reopened this Jan 2, 2021
@lowlighter
Copy link
Owner

Should be fixed now.
You can also use config_padding option to adjust cropping/padding if needed (defaults to 6%).

@yozachar
Copy link
Contributor Author

yozachar commented Jan 3, 2021

Superb, thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants