This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Refactor table rendering; Optional layout #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recently stumbled on the The layout option can be permanently discarded now. |
Merged
|
Feature was merged in #24 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to refactor the table rendering on the Moodle form page. I was hoping that would fix the fixed width issue, but it seems to be at the Moodle form level, and not the table level. It's refactored to core table renderings, so we're aboard that ship.
To fix the fixed width issue, I've added what I believe to be a harmless admin setting to render the Quickmail block pages under the course layout.
@rrusso, can you please take a look at it? I want to get your opinion on both the UI changes, and the layout option.
The aim was to fix #12.