New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: code duplication #183

Open

MarcoIeni opened this issue Apr 15, 2021 · 2 comments

Contributor

MarcoIeni commented Apr 15, 2021

I noticed there is a lot of code duplication in these CI jobs: Ubuntu-Stable, msvc-Nightly, msvc-Stable, mingw-Nightly, mingw-Stable.

They could be simplified in this way:
https://github.com/dandavison/delta/blob/e7d1e281ea539adb91a57c6945dea123fff1bd16/.github/workflows/ci.yml#L11-L39

Owner

lu-zero commented Apr 24, 2021

It is a good idea! If you have time to send a PR I'd land it.

Contributor Author

MarcoIeni commented May 27, 2021

Sorry but I don't have a lot of time in this period. If someone else wants to work on this, feel free :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment