Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a flag to disable conn ID generation and the check for retired conn IDs #2660

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

marten-seemann
Copy link
Member

This PR implements the proposed flag mentioned in ipfs/kubo#7526.

@marten-seemann marten-seemann force-pushed the retire-bug-backwards-compatilibity-bug branch from d492d18 to ac24b1b Compare July 8, 2020 11:07
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #2660 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2660   +/-   ##
=======================================
  Coverage   86.44%   86.44%           
=======================================
  Files         122      122           
  Lines        9763     9765    +2     
=======================================
+ Hits         8439     8441    +2     
  Misses        989      989           
  Partials      335      335           
Impacted Files Coverage Δ
conn_id_generator.go 90.32% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953f347...ce5ddc0. Read the comment docs.

@marten-seemann marten-seemann force-pushed the retire-bug-backwards-compatilibity-bug branch from ac24b1b to dd6171b Compare July 9, 2020 00:30
@marten-seemann marten-seemann force-pushed the retire-bug-backwards-compatilibity-bug branch from dd6171b to ce5ddc0 Compare July 9, 2020 03:41
@marten-seemann marten-seemann merged commit 8c66ccf into master Jul 10, 2020
@marten-seemann marten-seemann deleted the retire-bug-backwards-compatilibity-bug branch July 10, 2020 11:23
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants