Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't drop keys for key phase N before receiving a N+1-protected packet #2762

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

marten-seemann
Copy link
Member

Implements the fix suggested in quicwg/base-drafts#4079.

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #2762 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2762      +/-   ##
==========================================
+ Coverage   86.66%   86.67%   +0.01%     
==========================================
  Files         128      128              
  Lines        9999    10001       +2     
==========================================
+ Hits         8665     8668       +3     
+ Misses       1007     1006       -1     
  Partials      327      327              
Impacted Files Coverage Δ
internal/handshake/updatable_aead.go 97.06% <100.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c348c2...854940c. Read the comment docs.

@marten-seemann marten-seemann force-pushed the drop-old-keys-after-confirmed-key-update branch from af96570 to 854940c Compare September 10, 2020 04:12
@marten-seemann marten-seemann merged commit c5a132f into master Sep 10, 2020
@marten-seemann marten-seemann deleted the drop-old-keys-after-confirmed-key-update branch September 10, 2020 05:53
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants