use cryptographic random for determining skipped packet numbers #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2940 +/- ##
==========================================
- Coverage 86.18% 86.18% -0.00%
==========================================
Files 132 132
Lines 9160 9165 +5
==========================================
+ Hits 7894 7898 +4
- Misses 914 915 +1
Partials 352 352
Continue to review full report at Codecov.
|
marten-seemann
force-pushed
the
packet-number-skipping-cryptographic-random
branch
from
5b2588f
to
6b87198
Compare
| } | ||
| max := int32((1 << 31) - 1 - (1<<31)%uint32(n)) | ||
| v := r.Int31() | ||
| for v > max { |
There was a problem hiding this comment.
Maybe increase the fallback by powers of two? That would allow you to drop this loop / skip the loop in crypto/rand.Int()?
There was a problem hiding this comment.
Not sure I understand your comment. tbh, I just copied this from the math/rand implementation of Int63n. max should be very close to math.MaxInt32, so this loop is very unlikely to be executed.
marten-seemann
deleted the
packet-number-skipping-cryptographic-random
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @lucas-clemente suggested in #2905 (review).