Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for QUIC draft-34 #3031

Merged
merged 4 commits into from
Feb 13, 2021
Merged

add support for QUIC draft-34 #3031

merged 4 commits into from
Feb 13, 2021

Conversation

marten-seemann
Copy link
Member

QUIC draft-34 will (if everything goes according to plan at the IETF) become QUIC v1.

draft-34 uses a different salt for Initial packet encryption, and it changes the TLS extension code point for the QUIC transport parameter extension (yay!).

We're not allowed to deploy this version on the public internet yet. I added a note for SupportedVersions, so we don't forget that when cutting the next release.

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #3031 (615540f) into master (0b97ae5) will decrease coverage by 0.02%.
The diff coverage is 83.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3031      +/-   ##
==========================================
- Coverage   86.05%   86.04%   -0.02%     
==========================================
  Files         135      135              
  Lines        9472     9489      +17     
==========================================
+ Hits         8151     8164      +13     
- Misses        961      964       +3     
- Partials      360      361       +1     
Impacted Files Coverage Δ
http3/server.go 68.15% <42.86%> (-0.91%) ⬇️
internal/handshake/crypto_setup.go 66.83% <83.33%> (+0.24%) ⬆️
internal/handshake/initial_aead.go 100.00% <100.00%> (ø)
internal/handshake/tls_extension_handler.go 100.00% <100.00%> (ø)
internal/protocol/version.go 100.00% <100.00%> (ø)
server.go 82.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b97ae5...615540f. Read the comment docs.

@marten-seemann marten-seemann force-pushed the quic-draft-34 branch 2 times, most recently from 5c34f32 to e353633 Compare February 10, 2021 04:15
@marten-seemann
Copy link
Member Author

I got this wrong in part. draft-34 is draft-34, not version 1. Maybe (after IESG review), there'll be a version 1, which will be identical to draft-34 though.

I updated the PR accordingly.

@marten-seemann marten-seemann force-pushed the quic-draft-34 branch 2 times, most recently from 6255312 to 460d1ee Compare February 10, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants