Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix retry key and nonce for draft-34 #3062

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

marten-seemann
Copy link
Member

Fortunately, we haven't cut any release that officially supports draft-34 yet.

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #3062 (bd172b2) into master (2c45f2b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3062      +/-   ##
==========================================
+ Coverage   86.16%   86.16%   +0.01%     
==========================================
  Files         132      132              
  Lines        9355     9360       +5     
==========================================
+ Hits         8060     8065       +5     
  Misses        938      938              
  Partials      357      357              
Impacted Files Coverage Δ
internal/handshake/retry.go 75.00% <100.00%> (+6.58%) ⬆️
server.go 82.25% <100.00%> (ø)
session.go 77.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c45f2b...bd172b2. Read the comment docs.

@marten-seemann
Copy link
Member Author

The interop runner is happy with these changes.

@marten-seemann marten-seemann merged commit f513437 into master Mar 4, 2021
@marten-seemann marten-seemann deleted the fix-retry-draft-34 branch March 4, 2021 03:18
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant