Expose quic server closed err #3395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3395 +/- ##
=======================================
Coverage 85.40% 85.40%
=======================================
Files 135 135
Lines 9911 9911
=======================================
Hits 8464 8464
Misses 1065 1065
Partials 382 382
Continue to review full report at Codecov.
|
http3/server.go
Outdated
| @@ -255,6 +255,9 @@ func (s *Server) serveImpl(startListener func() (quic.EarlyListener, error)) err | |||
| for { | |||
| conn, err := ln.Accept(context.Background()) | |||
| if err != nil { | |||
| if errors.Is(err, quic.ErrServerClosed) { | |||
| return http.ErrServerClosed | |||
There was a problem hiding this comment.
Why do you convert to the http.ErrServerClosed here? The HTTP server might not be closed at this point.
There was a problem hiding this comment.
Yes, that's right. I reverted it, and there is no particular need to convert in order to reach the goal of this PR.
…en quic listener is closed" This reverts commit fb1f244.
marten-seemann
approved these changes
Apr 25, 2022
nmldiegues
pushed a commit
to chungthuang/quic-go
that referenced
this pull request
Jun 6, 2022
* expose quic server closed error * http3.Server's serving method returns http.ErrServerClosed when quic listener is closed * Revert "http3.Server's serving method returns http.ErrServerClosed when quic listener is closed" This reverts commit fb1f244.
41 tasks
sudarshan-reddy
pushed a commit
to sudarshan-reddy/quic-go
that referenced
this pull request
Aug 9, 2022
* expose quic server closed error * http3.Server's serving method returns http.ErrServerClosed when quic listener is closed * Revert "http3.Server's serving method returns http.ErrServerClosed when quic listener is closed" This reverts commit fb1f244.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide a way to check whether a returned error is expected or not from
quic.Listenerandhttp3.Server.