Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the http3.DataStreamer #3435

Merged
merged 1 commit into from
Jun 9, 2022
Merged

remove the http3.DataStreamer #3435

merged 1 commit into from
Jun 9, 2022

Conversation

marten-seemann
Copy link
Member

This interface was never really useful: It allowed converting the HTTP stream into a bare QUIC stream in the HTTP handler (server-side, that is), but it didn't allow the equivalent thing on the client side.

It also doesn't look like there's any interest in this function. Searching GitHub for http3.DataStreamer yields 5 results across 4 repos, which have 6 GitHub stars (in total!).

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #3435 (6e0d99a) into master (b5ef99a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3435      +/-   ##
==========================================
- Coverage   85.69%   85.67%   -0.01%     
==========================================
  Files         135      135              
  Lines        9955     9947       -8     
==========================================
- Hits         8530     8522       -8     
  Misses       1048     1048              
  Partials      377      377              
Impacted Files Coverage Δ
http3/response_writer.go 74.47% <ø> (-2.00%) ⬇️
http3/server.go 74.12% <100.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ef99a...6e0d99a. Read the comment docs.

@marten-seemann marten-seemann merged commit ccf897e into master Jun 9, 2022
@marten-seemann marten-seemann deleted the remove-datastreamer branch June 9, 2022 08:50
@MarcoPolo MarcoPolo mentioned this pull request Jul 7, 2022
41 tasks
sudarshan-reddy pushed a commit to sudarshan-reddy/quic-go that referenced this pull request Aug 9, 2022
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants