Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unreachable code after log.Fatal in fuzzing corpus generator #3496

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

Abirdcfly
Copy link
Contributor

https://pkg.go.dev/log#Fatal

Fatal is equivalent to Print() followed by a call to os.Exit(1).

see https://go.dev/play/p/fWIT3Iobb0A for example:

package main

import (
	"fmt"
	"log"
)

func main() {
	log.Fatalf("print and exit")
	fmt.Println("will not execute")
}

/* output
2009/11/10 23:00:00 print and exit

Program exited.
*/

@marten-seemann marten-seemann self-requested a review August 9, 2022 11:48
@marten-seemann marten-seemann changed the title fix minor unreachable code caused by log.Fatal fix unreachable code after log.Fatal in fuzzing corpus generator Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #3496 (bea5de0) into master (bea5de0) will not change coverage.
The diff coverage is n/a.

❗ Current head bea5de0 differs from pull request most recent head ddddf4a. Consider uploading reports for the commit ddddf4a to get more accurate results

@@           Coverage Diff           @@
##           master    #3496   +/-   ##
=======================================
  Coverage   85.69%   85.69%           
=======================================
  Files         136      136           
  Lines        9992     9992           
=======================================
  Hits         8562     8562           
  Misses       1052     1052           
  Partials      378      378           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marten-seemann
Copy link
Member

@Abirdcfly Can you please rebase this PR on top of the current master? The lint job is failing consistently, and I'm not sure if that's due to changes in the CI setup or if it's something related to this PR.

@marten-seemann
Copy link
Member

Can you rebase please, not merge master?

@marten-seemann
Copy link
Member

It worked, great! Thank you!

@marten-seemann marten-seemann merged commit dbb7a21 into quic-go:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants