Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prioritize sending ACKs over sending new DATAGRAM frames #3544

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

marten-seemann
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Base: 85.50% // Head: 85.50% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (3cde3e9) compared to base (62b8278).
Patch coverage: 94.29% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3544      +/-   ##
==========================================
- Coverage   85.50%   85.50%   -0.00%     
==========================================
  Files         138      138              
  Lines       10241    10254      +13     
==========================================
+ Hits         8756     8767      +11     
- Misses       1102     1103       +1     
- Partials      383      384       +1     
Impacted Files Coverage Δ
packet_packer.go 84.16% <88.24%> (-0.33%) ⬇️
connection.go 77.09% <100.00%> (ø)
datagram_queue.go 91.49% <100.00%> (+2.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marten-seemann marten-seemann merged commit c57ea6f into master Sep 9, 2022
@marten-seemann marten-seemann deleted the send-acks-when-sending-datagrams branch October 9, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants