Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperbolic cosine based estimator #73

Open
gaganbahga opened this issue Jul 9, 2021 · 0 comments
Open

hyperbolic cosine based estimator #73

gaganbahga opened this issue Jul 9, 2021 · 0 comments

Comments

@gaganbahga
Copy link

Hi @lucidrains thanks a lot for providing this implementation,
The authors of the paper proposed two types of estimators for Positive Random Features: the one based on exponential functions (referred to as SM+), and another one based on cosh, referred to as SM hyp+
But I think in the jax/TF implementation, and thus in this repository as well, the implementation is provided for the exponential one only.
In the paper, the authors mention that "Furthermore, the hyperbolic estimator provides additional accuracy improvements that are strictly better than those from SM+ 2m(x, y) with twice as many random features." So it seems like the default choice should have been the cosh based estimator, but it is not.
Would you happen to have more insights into this?
Also does the ortho_scaling=1 option switch on the regularized softmax-kernel (SMREG)? Is it recommended to use that anywhere? The authors have mentioned that ortho_scaling = 0.0 as the default hyperparameter choice though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant