fix(cluster): passing frozen natMap option causes crash

Closes: #887
redis · Jun 11, 2019 · 3bc6165 · 3bc6165
1 parent 1d606e4
commit 3bc6165
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/lib/cluster/index.ts b/lib/cluster/index.ts
@@ -438,7 +438,7 @@ class Cluster extends EventEmitter {
       const mapped = this.options.natMap[key]
       if (mapped) {
         debug('NAT mapping %s -> %O', key, mapped)
-        return mapped
+        return Object.assign({}, mapped)
       }
     }
     return typeof nodeKey === 'string' ? nodeKeyToRedisOptions(nodeKey) : nodeKey

diff --git a/test/functional/cluster/nat.js b/test/functional/cluster/nat.js
@@ -124,4 +124,31 @@ describe('NAT', () => {
 
     cluster.get('foo')
   })
+
+  it('keeps options immutable', (done) => {
+    const slotTable = [
+      [0, 16383, ['192.168.1.1', 30001]]
+    ]
+
+    new MockServer(30001, null, slotTable)
+
+    const cluster = new Redis.Cluster([{
+      host: '127.0.0.1',
+      port: 30001
+    }], Object.freeze({
+      natMap: Object.freeze({
+        '192.168.1.1:30001': Object.freeze({host: '127.0.0.1', port: 30001})
+      })
+    }))
+
+    const reset = spy(cluster.connectionPool, 'reset')
+
+    cluster.on('ready', () => {
+      expect(reset.secondCall.args[0]).to.deep.equal([
+        {host: '127.0.0.1', port: 30001, readOnly: false}
+      ])
+      cluster.disconnect()
+      done()
+    })
+  })
 })