fix(auth): emit authError when the server requiring a password

Issue: #258
redis · Mar 6, 2016 · c5ca754 · c5ca754 · mkozjak · Mar 24, 2016
1 parent 9b10251
commit c5ca754
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/lib/redis/event_handler.js b/lib/redis/event_handler.js
@@ -29,6 +29,9 @@ exports.connectHandler = function (self) {
       self._readyCheck(function (err, info) {
         if (err) {
           self.flushQueue(new Error('Ready check failed: ' + err.message));
+          if (!self.condition.auth && err.message.split(' ')[0] === 'NOAUTH') {
+            self.emit('authError', err);
+          }
         } else {
           self.serverInfo = info;
           if (self.connector.check(info)) {

diff --git a/test/functional/auth.js b/test/functional/auth.js
@@ -70,4 +70,19 @@ describe('auth', function () {
       done();
     });
   });
+
+  it('should emit "authError" when password is not provided', function (done) {
+    var server = new MockServer(17379, function (argv) {
+      if (argv[0] === 'info') {
+        return new Error('NOAUTH Authentication required.');
+      }
+    });
+    var redis = new Redis({ port: 17379 });
+    redis.on('authError', function (error) {
+      expect(error).to.have.property('message', 'NOAUTH Authentication required.');
+      redis.disconnect();
+      server.disconnect();
+      done();
+    });
+  });
 });