perf: Serialize error stack only when needed #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 31, 2021 15:03
|
Opened issue #1361 for the discussion |
|
Awesome! Thanks for the contribution! |
ioredis-robot
pushed a commit
that referenced
this pull request
Jun 4, 2021
## [4.27.4](v4.27.3...v4.27.4) (2021-06-04) ### Performance Improvements * Serialize error stack only when needed ([#1359](#1359)) ([62b6a64](62b6a64))
|
🎉 This PR is included in version 4.27.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.27.4](redis/ioredis@v4.27.3...v4.27.4) (2021-06-04) ### Performance Improvements * Serialize error stack only when needed ([#1359](redis/ioredis#1359)) ([62b6a64](redis/ioredis@62b6a64))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving Error stack serialization performance when
showFriendlyErrorStack=true.With current implementation there's about 30% overhead because the stack trace is serialized even when it's not actually needed.
With proposed change the overhead is somewhere between 1-5% on Node 14. There were improvements related to stack trace serialization in Node 12.
On the attached benchmark results, first run is on old code, second run on new code. Benchmark code also committed.