fix: handle malicious keys for hgetall #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 4.27.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
silverwind
reviewed
Aug 24, 2021
| @@ -427,7 +427,20 @@ Command.setReplyTransformer("hgetall", function (result) { | |||
| if (Array.isArray(result)) { | |||
| const obj = {}; | |||
There was a problem hiding this comment.
Could probably just use Object.create(null) here to avoid the performance hit from the additional check below.
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.27.8](redis/ioredis@v4.27.7...v4.27.8) (2021-08-18) ### Bug Fixes * handle malicious keys for hgetall ([#1416](redis/ioredis#1416)) ([7d73b9d](redis/ioredis@7d73b9d)), closes [#1267](redis/ioredis#1267)
This was referenced Jul 18, 2024
This was referenced Jul 29, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1267