Handle possible unhandled promise rejection with autopipelining+cluster #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deliberately add `asCallback` on the **same** Promise instance being returned,
not on a different Promise instance that resolves to the same thing.
Avoid this error:
```javascript
process.on('unhandledRejection', (reason) => console.log('unhandledRejection', reason));
const x = Promise.reject(new Error());
x.catch((e) => console.log('caught x', e));
const causesUnhandledRejection = Promise.resolve().then(() => x);
```
Related to redis#1466
TysonAndre
force-pushed
the
autopipelining-cluster-asCallback
branch
from
3acf1e8
to
47394d0
Compare
|
🎉 This PR is included in version 4.28.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.28.1](redis/ioredis@v4.28.0...v4.28.1) (2021-11-23) ### Bug Fixes * handle possible unhandled promise rejection with autopipelining+cluster ([#1467](redis/ioredis#1467)) ([6ad285a](redis/ioredis@6ad285a)), closes [#1466](redis/ioredis#1466)
This was referenced Jul 18, 2024
This was referenced Jul 29, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deliberately add
asCallbackon the same Promise instance being returned,not on a different Promise instance that resolves to the same thing.
Avoid this category of unhandledRejection errors:
Related to #1466