Allow convertObjectToArray to handle objects with no prototype #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
southpolesteve
force-pushed
the
patch-2
branch
from
95ecf73
to
9c21b7c
Compare
|
Nice catch! What about using |
southpolesteve
force-pushed
the
patch-2
branch
from
9c21b7c
to
7389f42
Compare
Currently this method expects `hasOwnProperty` to exist on the passed object. By using the method on `Object.prototype` instead, objects created with `Object.create(null)` can also be properly handled. Ran into this bug trying to pass graphQL input objects (heavily uses `Object.create(null)`) directly to hmset commands Use call
southpolesteve
force-pushed
the
patch-2
branch
from
7389f42
to
3bf6a9b
Compare
|
I was curious how Updated to use Object.keys + a for loop. Also added a test for an object without a prototype |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this method expects
hasOwnPropertyto exist on the passed object. By using the method onObject.prototypeinstead, objects created withObject.create(null)can also be properly handled.Ran into this bug trying to pass graphQL input objects (heavily uses
Object.create(null)) directly to hmset commands