Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve event "node error" to know which node (host+port) of cluster fired it #774

Closed
nolimitdev opened this issue Jan 8, 2019 · 1 comment
Labels

Comments

@nolimitdev
Copy link

When "node error" event happens on cluster node there is no info in its argument about which node error issued.

redis.on('node error', (error) => {
    log('Redis cluster node error:', error.message);
});
// Redis cluster node error: Connection is closed.
// Redis cluster node error: timeout

I tried to log entire "error" object but there is no info about node. It is important to quickly know host and port of node which has some problems.

@nolimitdev nolimitdev changed the title improve event "node error" to know which node (host+port) of cluster fired it Improve event "node error" to know which node (host+port) of cluster fired it Jan 8, 2019
@luin luin closed this as completed in #793 Feb 3, 2019
ioredis-robot pushed a commit that referenced this issue Feb 3, 2019
## [4.6.3](v4.6.2...v4.6.3) (2019-02-03)

### Bug Fixes

* add second arg to "node error" to know which node failed ([#793](#793)) ([6049f6c](6049f6c)), closes [#774](#774)
@ioredis-robot
Copy link
Collaborator

🎉 This issue has been resolved in version 4.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this issue Mar 1, 2024
## [4.6.3](redis/ioredis@v4.6.2...v4.6.3) (2019-02-03)

### Bug Fixes

* add second arg to "node error" to know which node failed ([#793](redis/ioredis#793)) ([6049f6c](redis/ioredis@6049f6c)), closes [#774](redis/ioredis#774)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants