-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
previously working rediss:// url does not work since 4.14.0 #940
Labels
Comments
luin
added a commit
that referenced
this issue
Aug 8, 2019
Just submitted a pull request for this issue. For now, the workaround would be changing the protocol to if (redisUri.startsWith('rediss://')) {
options.tls = { servername: new URL(redisUri).hostname };
redisUri = redisUri.replace('rediss://', 'redis://')
} After the pull request being merged, you can parse the tls option via URL directly: const redisUri = 'rediss://127.0.0.1/?tls[servername]=127.0.0.1'
const options = {
lazyConnect: true,
retryStrategy: () => 1000
};
const connection = new Redis(redisUri, options) |
This was referenced Aug 20, 2019
ioredis-robot
pushed a commit
that referenced
this issue
Aug 27, 2019
🎉 This issue has been resolved in version 4.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jan 16, 2020
This was referenced Jan 24, 2020
This was referenced Feb 22, 2020
This was referenced Mar 19, 2020
This was referenced Apr 20, 2020
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this issue
Mar 1, 2024
## [4.14.1](redis/ioredis@v4.14.0...v4.14.1) (2019-08-27) ### Bug Fixes * don’t clobber passed-in tls options with rediss:/ URLs ([#949](redis/ioredis#949)) ([ceefcfa](redis/ioredis@ceefcfa)), closes [#942](redis/ioredis#942) [#940](redis/ioredis#940) [#950](redis/ioredis#950) [#948](redis/ioredis#948)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
In 4.14.0 support for rediss:// url was introduced, but trying to connect to an url like this we get:
errors.
Before this version we used to have a workaround in our code for connecting to rediss:// urls which looked something like this:
which was working fine. (even in local development where we had a regular redis:// url)
With this newly introduced feature I haven't been able to find the right options to make this work.
It looks like the new parser set's
tls: true
in options, and we would need more detailed config here.The text was updated successfully, but these errors were encountered: