Adds ReadOnly mode for Standalone/Cluster mode #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cluster slots are now server with both Master and Slave instances - Fixes issue where slave node may be used for a write
|
Awesome! I'll check it out ASAP. |
| @@ -163,7 +164,8 @@ Redis.defaultOptions = { | |||
| enableReadyCheck: true, | |||
| autoResubscribe: true, | |||
| autoResendUnfulfilledCommands: true, | |||
| lazyConnect: false | |||
| lazyConnect: false, | |||
| readOnly: false | |||
There was a problem hiding this comment.
Since readOnly only works in cluster mode, we'd better only have it in cluster.js and listen to the ready event in the createNode method of cluster.js
|
Just added some comments |
|
Cool, I agree on both of them. I'll update the PR with changes accordingly later today. |
- Readonly is issued from cluster only and is removed from standalone client
luin
added a commit
that referenced
this pull request
Jun 11, 2015
Adds ReadOnly mode for Standalone/Cluster mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose is to use the client in a
readonlymode to scale reads.Each client individual issues a
readonlyonceready.Each node in the cluster is connected to, maintaining a pool of Master nodes and SlaveNodes.