-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support omitting SigningCertificate property #289
Comments
@hanadderia a new release will be out soon. There's a new |
Hello @luisgoncalves, Thank you for the swift update and for adding the Looking forward to the new release! Best regards, |
You're welcome. Let me know in case something is still off. The new release should be up by now. Best regards. |
Thanks @luisgoncalves, It's working as expected. <ds:Object>
<xades:QualifyingProperties xmlns:xades="http://uri.etsi.org/01903/v1.3.2#" Target="#">
<xades:SignedProperties xmlns:ns6="http://uri.etsi.org/01903/v1.4.1#" Id="_4cd24fac-f005-472b-be86-dd85b40c91bb-signedprops">
<xades:SignedSignatureProperties>
<xades:SigningTime>2024-08-09T00:00:00Z</xades:SigningTime>
</xades:SignedSignatureProperties>
</xades:SignedProperties>
</xades:QualifyingProperties>
</ds:Object> But, when enabled this property |
@hanadderia I missed the last part of your previous message. Right, I didn't add support for the verifier to process signatures without Do you also mean that the target system rejects it? |
Hello @luisgoncalves, No, the target system is accepting the signature, but the local verifier is not working. Thanks that will help a lot. |
Created #302 as a follow-up. It may be tricky to implement, so not sure if I'll end-up doing it. |
@hanadderia I've implemented the follow-up ticket, to be able to validate signatures without |
Add new configuration option to skip adding the
SigningCertificate
property if the signing certificate (or its issuer/serial) is included inKeyInfo
andKeyInfo
is signed.This is a bit against the recommendations (namely the baseline profile), but it may help in some cases.
Not including
SigningCertificate
is allowed by the spec if "incorporating the signing certificate within the ds:KeyInfo element and signing at least the signing certificate.".More details:
The text was updated successfully, but these errors were encountered: