Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staticman comments #18

Closed
luispuerto opened this issue Aug 17, 2018 · 4 comments
Closed

Staticman comments #18

luispuerto opened this issue Aug 17, 2018 · 4 comments
Assignees
Labels
enhancement 🎉 New feature or request wontfix 💔 This will not be worked on

Comments

@luispuerto
Copy link
Owner

I have to implement Staticman comments. Perhaps I can wait until gitlab implementation finish.

This tool could be interesting too.

Some documentation:

Staticman now supports [threaded comments](url
eduardoboucas/staticman#35) I have to check how mademistakes.com has done it.

@luispuerto luispuerto self-assigned this Aug 17, 2018
@luispuerto luispuerto added the enhancement 🎉 New feature or request label Aug 17, 2018
@VincentTam
Copy link
Contributor

VincentTam commented Sep 14, 2018

Perhaps I can wait until gitlab implementation finish.

No, you don't have to.

The working source code for the GitLab support was already there on Jul 23. Looking back, if one had forked the commit earlier and ran his/her own Staticman API instance, he/she would be able to post comments on GitLab Pages powered by Staticman without waiting for the future deplyment of Staticman v3 on the public production instance.

You may view my sample site, its source code, the source code for my own API instance and Heroku's guide for deploying an existing Node.js app (e.g. Staticman) to Heroku, who provides a free tier including 1000 free hours per month. (24 * 31 < 800).

180914-staticman

Some documentations:

@luispuerto
Copy link
Owner Author

@VincentTam hey!! thanks a lot for the info. I have to get time to look at it and implement staticman on my site. It's already implemented but I think it's in a basic way... but I haven't look thoroughly to the MM outdates in my template.

@VincentTam
Copy link
Contributor

@luisspuerto The setup guide in the linked PR mixes up GitLab repo config and API server config. An error in his guide is drowned between my discussions with the developer. Therefore, I've just finished writing my GitLab repo setup guide. A custom Staticman server setup guide is upcoming. Hope that helps.

@luispuerto
Copy link
Owner Author

Hey!

Thanks a lot for al the info @VincentTam I'll definitely take it a look in the near future.

@luispuerto luispuerto added the on hold ⏸️ Issues that I'm not going to work on now label Mar 15, 2019
@luispuerto luispuerto added on hold ⏸️ Issues that I'm not going to work on now wontfix 💔 This will not be worked on and removed on hold ⏸️ Issues that I'm not going to work on now labels Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎉 New feature or request wontfix 💔 This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants