Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm feature #21

Open
luizirber opened this issue May 6, 2020 · 0 comments
Open

wasm feature #21

luizirber opened this issue May 6, 2020 · 0 comments

Comments

@luizirber
Copy link
Owner

luizirber commented May 6, 2020

In sourmash I'm disabling default features to be able to use niffler in wasm environments. lzma and bzip2 require -sys crates, which are harder to compile properly in wasm32-unknown-unknown (browser) and wasm32-wasi (which does have a libc, but the toolchain still has issues with cross-compiling C code).

Pure rust implementations (like the one flate2 + miniz-oxide provide for gzip) are preferable in this case, because they will have less issues.

Having a wasm feature would be a shorthand for adding the formats that are supported.

Possible crates for adding more formats to wasm:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant