Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automatically include hash of vcpkg.json in cache key #95

Closed
Be-ing opened this issue Aug 6, 2021 · 2 comments
Closed

automatically include hash of vcpkg.json in cache key #95

Be-ing opened this issue Aug 6, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Be-ing
Copy link

Be-ing commented Aug 6, 2021

The user should not need to pass this as an additional appendix to the cache key. The ability to do this was recently added to the @actions/glob package but there has not yet been a new release published to npm.
@Be-ing Be-ing mentioned this issue Aug 6, 2021
Closed
@lukka
Copy link
Owner

lukka commented Aug 8, 2021

This is a good idea indeed, as it is saving an input that do not need to be specified and its default value is mostly covering the streamlined scenario.
Note: The following package could be used to search with a glob expression: https://www.npmjs.com/package/glob

@lukka lukka added the enhancement New feature or request label Aug 11, 2021
@lukka
Copy link
Owner

lukka commented Oct 17, 2021

This is implemented in run-vcpkg@v10!
Feel free to reopen this or a new ticket about any problem you may see.

@lukka lukka closed this as completed Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukka @Be-ing