Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change module ver #21

Merged
merged 4 commits into from
Jun 22, 2024
Merged

change module ver #21

merged 4 commits into from
Jun 22, 2024

Conversation

haturatu
Copy link
Contributor

I encountered a permission error with the current deno.json, so I upgraded the version using deno.json

@haturatu
Copy link
Contributor Author

No problem, here is the translation:

"changelog": "deno run --allow-read --allow-write https://deno.land/x/[email protected]/bin.ts"

@haturatu
Copy link
Contributor Author

I committed changes to copy images from the upload folder during the build process because uploaded images via /admin were not accessible due to incorrect image paths. Are there other solutions?

@oscarotero
Copy link
Member

Thanks, good catch!
Just one thing: can you move the copy("uploads") to plugins.ts file? It could be after this line.

@oscarotero oscarotero merged commit cbba300 into lumeland:main Jun 22, 2024
@oscarotero
Copy link
Member

thank you!

@haturatu
Copy link
Contributor Author

Thank you! it's solved.

Regarding another issue, it seems that the image Markdown format URL copying isn't working on my smartphone and my friend's Firefox browser when accessing:

https://cdn.jsdelivr.net/gh/lumeland/[email protected]/static/components/u-copy.js

If I can resolve it on my own, I'll report it in a separate repository. It works fine on Chromium.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants