Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpellBad undercurl not working in all terminals #26

Open
idnsunset opened this issue Mar 19, 2021 · 3 comments
Open

SpellBad undercurl not working in all terminals #26

idnsunset opened this issue Mar 19, 2021 · 3 comments

Comments

@idnsunset
Copy link

First thanks for making these awesome color schemes. I run into some trivial problems when running Vim in xterm.

The SpellBad highlighting to:

hi SpellBad guifg=NONE guibg=NONE gui=undercurl ctermfg=NONE ctermbg=NONE cterm=undercurl

However, not all terminals support undercurl, in xterm the badly spelled words are not styled distinctly. it would be better to set a ctermbg or ctermfg for it.

@lunacookies
Copy link
Owner

Screen Shot 2021-03-23 at 7 57 42 pm

Would it be better to make them red, too?

@idnsunset
Copy link
Author

I personally prefer to set spellCap, spellBad, spellLocal and spellRare to different colors, just like what's done in Gui.

@lunacookies
Copy link
Owner

I haven’t used Vim since June of last year, so I don’t really have the motivation to choose some good colour combinations for these. If you have the time would you mind creating a PR? If you do, don’t forget to edit the templates and not the generated colour scheme files themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants