-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace wrapping label with a div #6
Comments
Hi, @alex-e-leon <Checkbox
id="fname"
name="fname"
checkboxClass="icheckbox_square-blue"
increaseArea="20%"
/>
<label for="fname">First name</label> |
@luqin Sorry, I misunderstood how the label functions were supposed to work, looks good to me now. (although I feel like the label stuff would work better as a seperate wrapping component). |
@alex-e-leon OK. I will support this feature in react-icheck 1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Wrapping the checkbox/radio in a label may force some users to create a second label tag if this approach doesn't suit their design. While having multiple labels point to the same input element isn't against spec, anecdotally this may cause accessibility issues (screen readers may only read the first label found). See https://stackoverflow.com/questions/2829936/can-an-input-field-have-two-labels#answer-3992160
Can we follow the lead of the original icheck library and wrap it in a div instead?
The text was updated successfully, but these errors were encountered: