ODR violation between odbc & odbccr

[SpaceIm]

__get_connection is defined twice, in:

• odbc lib:

  unixODBC/DriverManager/SQLGetDiagRec.c

  Line 197 in f76a250

  DMHDBC __get_connection( EHEAD * head )

• odbccr lib:

  unixODBC/cur/SQLGetDiagRec.c

  Line 104 in f76a250

  DMHDBC __get_connection( EHEAD * head )

It may lead to duplicate symbol errors when both libs are linked.

Makefile:83: recipe for target 'all' failed
ld: error: duplicate symbol: __get_connection
>>> defined at SQLGetDiagRec.c
>>>            SQLGetDiagRec.o:(__get_connection) in archive /home/conan/w/prod/BuildSingleReference/.conan/data/odbc/2.3.7/_/_/package/8eabf8030762d318d462d63ad71a06248b66af41/lib/libodbccr.a
>>> defined at SQLGetDiagRec.c
>>>            SQLGetDiagRec.o:(.text+0x10) in archive /home/conan/w/prod/BuildSingleReference/.conan/data/odbc/2.3.7/_/_/package/8eabf8030762d318d462d63ad71a06248b66af41/lib/libodbc.a
clang-12: error: linker command failed with exit code 1 (use -v to see invocation)

[lurcher]

On 24/09/2022 14:27, SpaceIm wrote: |__get_connection| is defined both in: * odbc lib: https://github.com/lurcher/unixODBC/blob/f76a2504adf0aa4554547d7b9190640a9f410a45/DriverManager/SQLGetDiagRec.c#L197 * odbccr lib: https://github.com/lurcher/unixODBC/blob/f76a2504adf0aa4554547d7b9190640a9f410a45/cur/SQLGetDiagRec.c#L104 It may lead to duplicate symbol errors when both libs are linked.

The cursor lib should only be dynamically linked by the driver manager so its not a problem that should happen, but the function is not being used so I have removed it anyway.

[jubalh]

For reference: 3990a80

[SpaceIm]

Thanks

If cursor lib should only be dynamically linked by driver manager, why can it be built as a static library? Shouldn't it be always be built as a dynamic library regardless of static/shared options?

And you mean dynamically loaded or linked?

[lurcher]

On 24/09/2022 16:35, SpaceIm wrote: Thanks If cursor lib should only be dynamically linked by driver manager, why can it be built as a static library?

It can as that's one of the options that falls out of configure. Its conceivable that someone would want it. But just because I haven't explicitly stopped it from doing it is not the same as expecting it to be done.