Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request bind v1.45.0 new features #646

Closed
zhaozg opened this issue May 19, 2023 · 13 comments · Fixed by #649
Closed

request bind v1.45.0 new features #646

zhaozg opened this issue May 19, 2023 · 13 comments · Fixed by #649
Labels

Comments

@zhaozg
Copy link
Member

zhaozg commented May 19, 2023

http://docs.libuv.org/en/v1.x/metrics.html#c.uv_metrics_info

@squeek502
Copy link
Member

I'm working on this. Here's the full list of new stuff: https://docs.libuv.org/en/v1.x/search.html?q=1.45.0

@zhaozg zhaozg mentioned this issue May 20, 2023
@zhaozg
Copy link
Member Author

zhaozg commented May 20, 2023

Opps, I made a PR, #649.

@squeek502
Copy link
Member

No worries, I am working on the bindings for uv_thread_cpuinfo, uv_thread_getaffinity, uv_thread_setaffinity, uv_get_available_memory, and uv_cpumask_size.

@zhaozg
Copy link
Member Author

zhaozg commented May 20, 2023

@squeek502
Copy link
Member

I can't test it right now since I'm on Windows currently, but my first guess is that it's finding a regression in libuv.

@zhaozg
Copy link
Member Author

zhaozg commented May 20, 2023

Ok, I got ideas, some Mem error should be suppression. That's maybe come from lua 5.4.6.

@squeek502
Copy link
Member

squeek502 commented May 20, 2023

Those errors don't look like something we should suppress. Conditional jump or move depends on uninitialised value(s) and Use of uninitialised value pretty much always means there is a bug somewhere.

@squeek502
Copy link
Member

I'm getting the same valgrind errors in my branch that only updates Libuv, so this looks like either a bug on our end or a regression on Libuv's end.

@zhaozg
Copy link
Member Author

zhaozg commented May 20, 2023

Ok, We do double check.

@squeek502
Copy link
Member

My guess is that it's a regression in libuv. It wouldn't be the first time that our tests have found things that the libuv tests missed. I will investigate it soon.

@zhaozg
Copy link
Member Author

zhaozg commented May 20, 2023

My guess is that it's a regression in libuv. It wouldn't be the first time that our tests have found things that the libuv tests missed. I will investigate it soon.

I add --track-origins=yes for valgrind in https://github.com/luvit/luv/actions/runs/5031004869/jobs/9023801782, that report Uninitialised value value was created by a heap allocation in libuv side,
uv__iou_fs_statx call by uv_fs_stat, I can say https://github.com/libuv/libuv/blob/v1.x/src/unix/linux.c#L816
come from libuv/libuv#3952,

@zhaozg
Copy link
Member Author

zhaozg commented May 20, 2023

Can you report this to libuv, I have unclear English communication ability. ☹

@squeek502
Copy link
Member

squeek502 commented May 20, 2023

Sure, I will make an issue in a bit.

EDIT: libuv/libuv#4008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants