Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block should use LazyLoad (or at least be able to do so) #28

Closed
JohnnyMcWeed opened this issue Jun 26, 2020 · 4 comments · Fixed by #29
Closed

Image block should use LazyLoad (or at least be able to do so) #28

JohnnyMcWeed opened this issue Jun 26, 2020 · 4 comments · Fixed by #29
Assignees

Comments

@JohnnyMcWeed
Copy link
Contributor

What steps will reproduce the problem?

Use image block

What is the expected result?

LazyLoad or option for it

What do you get instead? (A Screenshot can help us a lot!)

No LazyLoad at all

@nadar
Copy link
Member

nadar commented Jun 26, 2020

Could you make an example?

@JohnnyMcWeed
Copy link
Contributor Author

Currently the image block view (https://github.com/luyadev/luya-bootstrap4/blob/master/src/views/blocks/ImageBlock.php) is not using Luya's LazyLoad. This could improve the overall performance of a site.
Therefore this should be either implemented by default or having a block option to use it (https://github.com/luyadev/luya-bootstrap4/blob/master/src/blocks/ImageBlock.php).
(Related to luyadev/luya#2031 as "alt" and "title" attributes should be there aswell :) )

@nadar
Copy link
Member

nadar commented Jun 27, 2020

A configuration option would be great, yes! Would you like to send a PR?

@JohnnyMcWeed
Copy link
Contributor Author

I'll go for it as soon as the LazyLoad is ready, so we can integrate the attributes at the same time :)

@JohnnyMcWeed JohnnyMcWeed mentioned this issue Jul 21, 2020
@nadar nadar closed this as completed in #29 Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants