Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwoColumnOperatorTransformer bugs #144

Closed
TommyMatthews opened this issue Dec 5, 2023 · 2 comments · Fixed by #183
Closed

TwoColumnOperatorTransformer bugs #144

TommyMatthews opened this issue Dec 5, 2023 · 2 comments · Fixed by #183
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@TommyMatthews
Copy link
Contributor

Input check for columns needs fixing as it currently

  • Does not raise a value error when instantiated with empty columns list
  • Does not raise a type error when columns instantiated with a string
@TommyMatthews TommyMatthews added bug Something isn't working good first issue Good for newcomers labels Dec 5, 2023
@ChaitanMohr ChaitanMohr self-assigned this Feb 9, 2024
@ChaitanMohr
Copy link
Contributor

An existing check grouped these two issues together with an and statement, so only raised a ValueError when both issues were happening. Split that up into two separate checks instead to raise a ValueError or TypeError.

@ChaitanMohr
Copy link
Contributor

Also written 2 unit tests to check these distinct potential errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants