Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring ArbitraryImputer in line with new testing setup #207

Closed
limlam96 opened this issue Apr 2, 2024 · 2 comments
Closed

Bring ArbitraryImputer in line with new testing setup #207

limlam96 opened this issue Apr 2, 2024 · 2 comments
Assignees

Comments

@limlam96
Copy link
Contributor

limlam96 commented Apr 2, 2024

What?

There are a few required changes for this, summarised below from (#150)

  • Update "minimal attribute dict" fixture in conftest.py with the correct set of minimal arguments required
  • Set up the TestInit, TestFit, TestTransform, and TestOtherBaseBehaviour methods to inherit the appropriate test classes (see an example Updated Mapping Transformer Tests) and then copy the setup_class class method into each test class, changing transformer_name to the transformer you are testing.
  • Delete any unnecessary tests from original transformer test file (i.e. tests testing inherited behaviour that is now tested by the inherited test classes).
  • Debug the failing tests from the base test suite.
  • Bring the test file in line with best practices by insuring there are no implementation tests (in this case looks like these will have been removed as part of the base test changes)
  • Bonus: If you identify any gaps in the testing, please set up new issues :)

Why?
Revamp tubular testing to make package more maintainable/modifiable

@limlam96
Copy link
Contributor Author

limlam96 commented Apr 3, 2024

Going to pick this one up myself to test the process

@limlam96
Copy link
Contributor Author

completed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant