You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What?
This collection of transformers needs a bit of a rework before setting up the new testing framework, the classes are set up inconsistently in a way that does not support the new approach.
Suggested actions:
BaseDateTransformer to implement transform method, that calls check_columns_are_date_or_datetime
Deprecate cast_columns_to_datetime from BaseDateTransformer, throw error directing to existing ToDatetimeTransformer if columns fail type checks
Some complications are introduced by transformers checking for datetime OR date type, which allows the possibility of mismatched types across manipulated columns. Suggest we make transformers more opinionated, introduce a type argument that allows date or datetime and checks accordingly. This would allow us to deprecate '_cast_non_matching_columns', 'match_column_datatypes'
Other thoughts:
We have DateDiffLeapYearTransformer and DateDifferenceTransformer, can these be condensed?
The text was updated successfully, but these errors were encountered:
What?
This collection of transformers needs a bit of a rework before setting up the new testing framework, the classes are set up inconsistently in a way that does not support the new approach.
Suggested actions:
Other thoughts:
The text was updated successfully, but these errors were encountered: