Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narwhalify BaseImputer #314

Open
davidhopkinson26 opened this issue Oct 7, 2024 · 0 comments
Open

Narwhalify BaseImputer #314

davidhopkinson26 opened this issue Oct 7, 2024 · 0 comments
Assignees

Comments

@davidhopkinson26
Copy link
Contributor

davidhopkinson26 commented Oct 7, 2024

What

make BaseImputer polars compatible while maintaining backwards compatibility with pandas.

Why?

Making the project polars compatible for speed benefits. Narwhals allows us to do this piece by piece and maintain compatibility between components as it makes it possible to pass pandas dataframes to polars logic. This involves converting between pandas/polars dataframes.

Without converting parent classes there will be lots of switching back and forth due to calls to super() so we should aim to convert foundational elements early on.

How?

convert logic in BaseImputer to function with polars dataframes and add narwhalify decorators to methods to ensure compatibility with pandas dataframes.

Update testing where required. This will require additional tests or parameterisation for polars workflows.

@davidhopkinson26 davidhopkinson26 changed the title Make BaseImputer Narwhalify BaseImputer Oct 7, 2024
@alphanumericmale alphanumericmale self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants