Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Arabic support #249

Merged
merged 8 commits into from
Sep 6, 2021
Merged

Better Arabic support #249

merged 8 commits into from
Sep 6, 2021

Conversation

mal7othify
Copy link
Contributor

This PR is about enhancing Arabic pages. It contains the following:

  • Loaded Arabic font. (Tajawal font)
  • Reduce space between letters.
  • English lowercase letters used between Arabic words.
  • Ltr direction for the markdown code snippets. (with code sample).
  • Improved Arabic wording.
  • Nav_list underline is now fixed for Arabic pages.

Check the following screenshots:

Before After
Before font screenshot After font screenshot
Before code sample After code sample

lxndrblz
lxndrblz approved these changes Sep 6, 2021
View reviewed changes
Copy link
Owner

@lxndrblz lxndrblz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mal7othify Thanks for your contribution. It mostly looked good to me. I only made some minor tweaks.

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lxndrblz lxndrblz merged commit 8ad28e8 into lxndrblz:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxndrblz lxndrblz lxndrblz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mal7othify @lxndrblz