Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: inconsistent naming of gh release assets #1463

Closed
axel-kah opened this issue Jul 6, 2024 · 0 comments · Fixed by #1464
Closed

ci: inconsistent naming of gh release assets #1463

axel-kah opened this issue Jul 6, 2024 · 0 comments · Fixed by #1464

Comments

@axel-kah
Copy link
Contributor

axel-kah commented Jul 6, 2024

Hi,
I'm in the process of proposing a simpler and cross platform approach to enable a lychee pre-commit hook which uses the pre-built binaries. For that to work cross platform, the filenames of the release assets need a fix. linux assets are all consistent but differ from macos and windows assets.

I prepared a PR which renames the windows and mac assets to match the linux pattern. I figured while I'm at it, I could also strip the version from the filenames. This unlocks the possibility to offer a permalink to the latest release, without having to know the version:

https://docs.github.com/en/repositories/releasing-projects-on-github/linking-to-releases#linking-to-the-latest-release

This makes it trivial for downstream consumers to automate the download of the latest binary (after weighting the pro's and con's of course 😉).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant