Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python dist to work with toastedmarshmallow/webargs #241

Open
ryan-lane opened this issue Jan 3, 2020 · 2 comments
Open

Fix python dist to work with toastedmarshmallow/webargs #241

ryan-lane opened this issue Jan 3, 2020 · 2 comments
Assignees

Comments

@ryan-lane
Copy link
Contributor

toastedmarshmallow includes a fork of marshmallow, but webargs lists marshmallow as a dependency. To fix webarg's dependency resolution, it's necessary to install the marshmallow fork via -e git+..., but that doesn't work for setup.py dependencies.

We're not actively using webargs currently, but some upcoming changes for using marshmallow for API request validation will use webargs. Using marshmallow without toastedmarshmallow has a high performance cost, so we need to figure out a way to make everything play nice.

@ryan-lane
Copy link
Contributor Author

Adding @rowillia as he made toastedmarshmallow and may have some ideas

@ryan-lane
Copy link
Contributor Author

For now I'll pull webargs out to fix the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants