Fix EDMF for use with >3.2 #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getRecords` function inside Ember Data treats attributes differently. Where once the it would set each attribute on the internal model with `options[]=` (triggering the setter/getter we install to properly install EDMF) it now calls `InternalModel#setDirtyAttribute`. The deciding factor for whether something is an `attribute` was based off the `meta` set on the installed CP's. We're instead telling the `InternalModel#fields` function to properly recognize fragments as `"fragments"` which bypasses the `setDirtyAttribute` call and instead does the default behavior from before. Reopening the Model in this way preserves the previous behavior. I suspect, this will likely need a large refactor when RFC293 lands https://github.com/igorT/rfcs/blob/17e8f97049452ae18d3b12ee23c4858a6d5e0bfd/text/0000-model-data.md Luckily, I believe IgorT is already begun the work there with this spike listed in the above RFC: https://github.com/igorT/ember-data.model-fragments/tree/igor/model-data
|
The specific part we are overriding to do the default behavior is this switch statement: |
|
@rondale-sc awesome it's so nice seeing a green build! @workmanw hows this look to you? |
|
Seems reasonable to me (FWIW)... |
workmanw
approved these changes
Aug 1, 2018
|
@rondale-sc I assume the model-fragment tests were broken with ember-data 3.2 prior to this fix? Just want to make sure we have some kind of test coverage. |
|
Yes, a number of tests failed before this PR when ran against [email protected]+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getRecordsfunction inside Ember Data treats attributesdifferently.
Where once the it would set each attribute on the internal model with
options[]=(triggering the setter/getter we install to properlyinstall EDMF) it now calls
InternalModel#setDirtyAttribute.The deciding factor for whether something is an
attributewas basedoff the
metaset on the installed CP's. We're instead telling theInternalModel#fieldsfunction to properly recognize fragments as"fragments"which bypasses thesetDirtyAttributecall and insteaddoes the default behavior from before.
Reopening the Model in this way preserves the previous behavior.
I suspect, this will likely need a large refactor when RFC293 lands
https://github.com/igorT/rfcs/blob/17e8f97049452ae18d3b12ee23c4858a6d5e0bfd/text/0000-model-data.md
Luckily, I believe IgorT is already begun the work there with this spike
listed in the above RFC:
https://github.com/igorT/ember-data.model-fragments/tree/igor/model-data