Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on the pseudo code of arxiv paper #881

Open
treya-lin opened this issue Sep 12, 2024 · 0 comments
Open

Question on the pseudo code of arxiv paper #881

treya-lin opened this issue Sep 12, 2024 · 0 comments

Comments

@treya-lin
Copy link

treya-lin commented Sep 12, 2024

Hi thanks for your great work. I am reading the paper and noticed a bug which I assume to be a typo.

In the arxiv paper (https://arxiv.org/abs/2303.00747), Listing1 shows the pseudo code for smoothing. I noticed that the min-cut modification implementation seems incorrect. instead of

sc = scores[t]
...
pdx = i + max_len //2
qdx = i + max_len
min_sp = argmin(scores[pdx:qdx])
segs.append((start, pdx+min_sp))

shouldn't it be like this?

sc = scores[i]
...
pdx = start + max_len //2
qdx = start + max_len
min_sp = argmin(scores[pdx:qdx])
segs.append((start, pdx+min_sp))

I also checked the code in this repo, which seems to be consistent with the corrected version. Correct me if I misunderstood it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant