Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About how to help merge PRs #46

Open
pplam opened this issue Jun 27, 2022 · 5 comments
Open

About how to help merge PRs #46

pplam opened this issue Jun 27, 2022 · 5 comments

Comments

@pplam
Copy link
Contributor

pplam commented Jun 27, 2022

Hi @m-novikov , is there something I can do to help merging PRs more efficiently? Please let me know if you have any feedback or suggestions :)

@m-novikov
Copy link
Owner

m-novikov commented Jun 28, 2022

This mostly question of my personal time :) I'll plan to review and merge your PRs by the end of this week.
As I don't have too much time and don't want to block you I'll probably add comments and merge them regardless creating follow up issues.
I also wanted to ask what is your use case for the project, because I plan to introduce some changes while working on #42

@m-novikov
Copy link
Owner

I merged a couple some PRs, please rebase existing to the latest main.

@pplam
Copy link
Contributor Author

pplam commented Jun 28, 2022

Thanks for your time @m-novikov , I will do it tomorrow

@pplam
Copy link
Contributor Author

pplam commented Jun 28, 2022

This mostly question of my personal time :) I'll plan to review and merge your PRs by the end of this week. As I don't have too much time and don't want to block you I'll probably add comments and merge them regardless creating follow up issues. I also wanted to ask what is your use case for the project, because I plan to introduce some changes while working on #42

I already understand your situation, I also work here on weekdays, so my PRs will be quite a lot :)

My use case is to parse real-world SQL files then do some analysis on the parse tree. So I'd like to make contributions to make it support as more PostgreSQL grammar as possible, and produce better parse tree and less parse errors.

And by now, I mainly follow the grammar defined in PostgreSQL's docs.

By the way, the ideas described in #42 are great, I fully support such a plan.

@pplam
Copy link
Contributor Author

pplam commented Jun 29, 2022

Hi @m-novikov

I just rebased #40, #41 and #43 , please help review again at your convenient, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants