Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage support #42

Closed
alexpersian opened this issue Aug 4, 2015 · 6 comments
Closed

Carthage support #42

alexpersian opened this issue Aug 4, 2015 · 6 comments

Comments

@alexpersian
Copy link

Do you have any plans as of yet to implement Carthage support for this repo?

Fantastic project by the way!

@AndrewSB
Copy link

AndrewSB commented Aug 4, 2015

+1

@mac-cain13
Copy link
Owner

@alexpersian thanks for your compliments and for using the project!

@AndrewSB gave Carthage support a shot in PR #46. I think he came to the correct conclusion that since R.swift is not a Dynamic Framework, but a extra buildstep you add to a project we can't add Carthage support.

Carthage in the end is "just" an amazing dynamic framework builder where you still have to do the integration yourself. The only thing we "abuse" Cocoapods for is the integration part, since that is exactly the main thing Carthage is not doing (on purpose) this is a no go.

If I'm seeing this wrong, please let me know!

@alexpersian
Copy link
Author

Thanks for the response and explanation. The main advantage I personally see with Carthage over CocoaPods is you are not forced into using a workspace with that additional overhead. But I can see your point, especially since this isn't a Dynamic Framework.

Also props to @AndrewSB for building a PR to try and make it possible.

@mac-cain13
Copy link
Owner

Carthage is a awesome tool, totally agree on that! It's just that it's not so suited for R.swift, would absolutely recommend it for including frameworks. :)

@tomlokhorst
Copy link
Collaborator

Update per R.swift version 1.0:

The generated code references the Rswift library, which is available through Carthage: https://github.com/mac-cain13/R.swift.Library#carthage

@alexpersian
Copy link
Author

Great news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants