Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module declares its path as: github.com/HdrHistogram/hdrhistogram-go but was required as: github.com/codahale/hdrhistogram #60

Open
shtrom opened this issue Oct 21, 2021 · 2 comments

Comments

@shtrom
Copy link

shtrom commented Oct 21, 2021

Installing locally with go get github.com/mjibson/sqlfmt, I get the following error:

go: downloading github.com/mjibson/sqlfmt v0.4.0
...
go get: github.com/codahale/hdrhistogram@none updating to
        github.com/codahale/[email protected]: parsing go.mod:
        module declares its path as: github.com/HdrHistogram/hdrhistogram-go
                but was required as: github.com/codahale/hdrhistogram

It looks like the simplest fix is to add a go.mod file with the correct path mapping HdrHistogram/hdrhistogram-go#30 (comment)

@maddyblue
Copy link
Owner

I've tried a few times to add a go.mod and the problem is cockroach's go.mod causes problems. I'm no longer in the Go space and I'm unlikely to try again. Would accept a PR though.

@maddyblue
Copy link
Owner

For anyone that tries this: use https://github.com/cockroachdb/cockroach-gen in a replace module for cockroach to avoid any need on Make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants