Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library relies on deprecated pkg_resources #88

Closed
gotmax23 opened this issue Aug 15, 2023 · 2 comments · Fixed by #105
Closed

Library relies on deprecated pkg_resources #88

gotmax23 opened this issue Aug 15, 2023 · 2 comments · Fixed by #105

Comments

@gotmax23
Copy link
Contributor

This package imports pkg_resources

from pkg_resources import Requirement as Req

which is deprecated. Simply importing the package raises a DeprecationWarning. The library should migrate to packaging.requirements.Requirement instead of pkg_resources.Requirement.

@felixfontein
Copy link

@gotmax23
Copy link
Contributor Author

This is failing on Python 3.12: https://github.com/ansible-collections/community.docker/actions/runs/7513305230/job/20454910945?pr=754

That is because the package is missing an explicit dependency on setuptools, but it looks like that was fixed on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants