Fix exclusion path filter in CI #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-bader
approved these changes
Jul 20, 2024
|
Classic OR logic error in my head 😞 |
|
Easy to miss, especially as it's a missing parameter and poorly named. I assumed exclusions had precedence myself, hence this useless commit 😅 ac7d571 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerShell steps in CI are currently executed on all PRs because
path-filteronly requires one filter to match. As a result the manifest exclusion matches any file in the repo and triggers the PowerShell steps. E.g. the PowerShell tests should not have been executed in #368PR fixes this by adding the missing
predicate-quantifier: 'every'parameter to require all filters to match.Note: Workflow and VSCode will warn about the
predicate-quantifiernot being a parameter. This is being fixed in dorny/paths-filter#226